polynux
/
tarteauxmyrtilles
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #440 from prudloff-insite/internal-scripts 

useExternalJs should only apply to internal scripts
This commit is contained in:
Amauri CHAMPEAUX 2020-04-22 17:19:31 +02:00 committed by GitHub
parent de701ba421 e555e47ecd
commit abf235b37f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
tarteaucitron.js
View File

@ -252,12 +252,12 @@ var tarteaucitron = {
document.getElementsByTagName('head')[0].appendChild(linkElement);
}
// Step 2: load language and services
tarteaucitron.addScript(pathToLang, '', function () {
tarteaucitron.addInternalScript(pathToLang, '', function () {
if(tarteaucitronCustomText !== ''){
tarteaucitron.lang = tarteaucitron.AddOrUpdate(tarteaucitron.lang, tarteaucitronCustomText);
}
tarteaucitron.addScript(pathToServices, '', function () {
tarteaucitron.addInternalScript(pathToServices, '', function () {
// css for new middle bar
@ -433,7 +433,7 @@ var tarteaucitron = {
html += '</div>';
}
tarteaucitron.addScript(tarteaucitron.cdn + 'advertising.js?v=' + tarteaucitron.version, '', function () {
tarteaucitron.addInternalScript(tarteaucitron.cdn + 'advertising.js?v=' + tarteaucitron.version, '', function () {
if (tarteaucitronNoAdBlocker === true || tarteaucitron.parameters.adblocker === false) {
// create a wrapper container at the same level than tarteaucitron so we can add an aria-hidden when tarteaucitron is opened
@ -1422,7 +1422,7 @@ var tarteaucitron = {
return 'en_US';
}
},
"addScript": function (url, id, callback, execute, attrName, attrVal) {
"addScript": function (url, id, callback, execute, attrName, attrVal, internal = false) {
"use strict";
var script,
done = false;
@ -1456,11 +1456,14 @@ var tarteaucitron = {
}
}
if ( !tarteaucitron.parameters.useExternalJs ) {
if ( !tarteaucitron.parameters.useExternalJs || !internal ) {
document.getElementsByTagName('head')[0].appendChild(script);
}
}
},
"addInternalScript": function (url, id, callback, execute, attrName, attrVal) {
tarteaucitron.addScript(url, id, callback, execute, attrName, attrVal, true);
},
"makeAsync": {
"antiGhost": 0,
"buffer": '',
@ -1490,7 +1493,7 @@ var tarteaucitron = {
return;
}
tarteaucitron.makeAsync.antiGhost += 1;
tarteaucitron.addScript(url, '', function () {
tarteaucitron.addInternalScript(url, '', function () {
if (document.getElementById(id) !== null) {
document.getElementById(id).innerHTML += "<span style='display:none'>&nbsp;</span>" + tarteaucitron.makeAsync.buffer;
tarteaucitron.makeAsync.buffer = '';